fix: Find aslrefs in precomputed derivatives, remove bad connection #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
fix/precomputed-derivs
branch
from
dea484c to
6d3d6f3
Compare
effigies
changed the title
Contributor
Author
|
I'm able to rerun with PEPolar fieldmaps now. |
tsalo
approved these changes
May 22, 2025
Member
tsalo
left a comment
tsalo
left a comment
There was a problem hiding this comment.
These changes look good to me. Thanks!
effigies
added a commit
to nipreps/fmriprep
that referenced
this pull request
May 22, 2025
Discovered while testing precomputed derivatives in aslprep, which imports `fmriprep.utils.bids.collect_fieldmaps`. See PennLINC/aslprep#518. For PEPolar fieldmaps, the fieldmap reference is often `desc-epi_fieldmap.nii.gz`, as opposed to `desc-magnitude_fieldmap.nii.gz`. IMO, it would be good to change `desc-{epi,preproc}_fieldmap.nii.gz` to `desc-preproc_{magnitude,fieldmap}.nii.gz`, but this is what it is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
These changes are aimed at getting aslprep to accept precomputed derivatives using the following commands:
aslrefs weren't being found due to the datatype being declared asfunc. Once found, the fallback workflow to generating the hmcref attempted to push adummy_scansvalue tohmcref_buffer, which duplicated an input frominputnode. Since this only was being passed through a series ofIdentityInterfaces and never used, I just stripped that field out of the fit workflow altogether.