-
Notifications
You must be signed in to change notification settings - Fork 18
Write out aslref CBF + ATT in minimal mode #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does this include reports? Generally, the more reports you can generate without rerunning, the better. |
|
I currently have CBF reports and confounds as part of the "resampling" level. If I move those up to "minimal" I don't think I'll have anything that's specific to "resampling". Happy to do it, but not sure what resampling should be used for. |
Co-authored-by: Chris Markiewicz <[email protected]>
|
I pretty much only have "resampling" there for tedana users or other experimenters. Confounds are in full, for fmriprep. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 83.24% 83.18% -0.07%
==========================================
Files 38 38
Lines 4101 4086 -15
==========================================
- Hits 3414 3399 -15
Misses 687 687 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
That works for me. I'll make a note that "resampling" is the same as "minimal" (for now) in the documentation and I'll move the report generation to the minimal level. |
| return workflow | ||
| # If we want aslref-space outputs, then call the appropriate workflow | ||
| aslref_out = bool(nonstd_spaces.intersection(('func', 'run', 'asl', 'aslref', 'sbref'))) | ||
| aslref_out &= config.workflow.level == 'full' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this logical and...
Closes none, but addresses a bug detected by @effigies.
In minimal mode, ASLPrep runs the CBF workflow, but doesn't currently write out the CBF derivatives. This is a bug. ASLPrep should write out aslref-space CBF derivatives no matter what, since they're the main output of interest.
Changes proposed in this pull request
init_ds_asl_native_wfin the following ways:init_asl_fit_wf.asl_outputwas True. Now, that parameter only determines if the aslref ASL file is written out.init_ds_asl_native_wfto before the workflow is returned when minimal mode is enabled.init_ds_asl_native_wfif aslref outputs are requested and full mode is enabled or minimal/resampling mode is enabled. This way, if you're running in full mode and you don't want aslref outputs, you don't get them. However, if you're running in minimal or resampling mode, you get out aslref CBF and ATT outputs no matter what.