Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented May 22, 2025

Closes #530. I still need to modify the boilerplate, which means I need to extract the M0 TR in the workflow function instead of within a node.

Changes proposed in this pull request

image

Affected integration tests

  • pcasl_multipld
  • pcasl_singlepld_ge
  • pcasl_singlepld_siemens
  • qtab
  • test_001
  • test_002
  • test_003

@tsalo tsalo added the enhancement New feature or request label May 22, 2025
@tsalo
Copy link
Member Author

tsalo commented May 22, 2025

@caugolm would you mind taking a look at this?

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

Attention: Patch coverage is 51.16279% with 21 lines in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (8076479) to head (84b1df6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
aslprep/utils/asl.py 38.23% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   83.15%   82.82%   -0.34%     
==========================================
  Files          38       38              
  Lines        4026     4069      +43     
==========================================
+ Hits         3348     3370      +22     
- Misses        678      699      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo marked this pull request as ready for review May 23, 2025 17:56
@tsalo tsalo merged commit 50e7b0d into main May 24, 2025
26 checks passed
@tsalo tsalo deleted the m0tr-scaling branch May 24, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scale M0 when TR is short

4 participants