Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented May 27, 2025

Closes #520.

Changes proposed in this pull request

  • Add a reportlet showing the brain mask.

@tsalo tsalo added the enhancement New feature or request label May 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.61%. Comparing base (e464b62) to head (4da4e65).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
aslprep/utils/plotting.py 23.52% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   76.06%   75.61%   -0.45%     
==========================================
  Files          38       38              
  Lines        4219     4237      +18     
==========================================
- Hits         3209     3204       -5     
- Misses       1010     1033      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo
Copy link
Member Author

tsalo commented May 28, 2025

Something's up with my recent improvements and the jobs are stalling. I need to figure out what's going on there.

@tsalo
Copy link
Member Author

tsalo commented May 29, 2025

Here's the figure from test_002 (GE data). The aslref image shouldn't have that terrible sphere around it, so I think something needs to be fixed. Also the brain mask looks terrible.
image

@tsalo tsalo marked this pull request as ready for review May 29, 2025 20:32
@tsalo
Copy link
Member Author

tsalo commented May 29, 2025

Many of the test datasets' brain masks look terrible, but I think that needs to go in a separate PR. The only lingering thing here is whether the changes to the CBF maps look good.

@tsalo
Copy link
Member Author

tsalo commented May 30, 2025

The positive-only mode has a symmetric colorbar for some reason.

test_002

@tsalo
Copy link
Member Author

tsalo commented May 30, 2025

The positive-only mode looks good now, but the colorbar for the positive+negative mode is centered ~40 (halfway between -20 and 100), so I think I just need to accept that it's going to range from -100 to 100 with a symmetric colorbar :(.

@tsalo
Copy link
Member Author

tsalo commented May 30, 2025

The results look alright now. I'm going to merge.

@tsalo tsalo merged commit 6104e47 into main May 30, 2025
26 checks passed
@tsalo tsalo deleted the plot-mask branch May 30, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plot brain mask

3 participants