-
Notifications
You must be signed in to change notification settings - Fork 18
Apply MCFLIRT to register m0scan to aslref image #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 76.08% 76.06% -0.03%
==========================================
Files 38 38
Lines 4106 4219 +113
==========================================
+ Hits 3124 3209 +85
- Misses 982 1010 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The aslref image looks completely different too, so it must be due to the changes I made in the aslref workflow. |
|
Okay, I think I've fixed all of the issues. @mattcieslak would you be willing to review this at some point? |
mattcieslak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any problems here, but it does remind me of an issue that Phil and Chris were having where they could only successfully coregister the ASL data to the structural scans if they used a cbf image. I think some of the logic you implemented here might also be used to address that problem in a future PR


Closes #550.
Changes proposed in this pull request
<source_entities>_from-m0scan_to-aslref_mode-image_xfm.txt, to register a separate M0 scan to the ASL reference image. If the separate M0 scan is used as the reference image, then this will be an identity transform.