Skip to content

test(parity): stream — duplexPair, finished({error:false}), compose(asyncGenFn), Readable.from(rejectedPromise) (#1531/#1532) - #1579

Merged
proggeramlug merged 2 commits into
mainfrom
feat/stream-iter26
May 24, 2026
Merged

proggeramlug merged 2 commits into
mainfrom
feat/stream-iter26

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Iter-26 stream tests — final niche surface

Four genuinely-different tests for the last unaudited stream behaviors:

Test Status Tracking
duplex-pair/wired-comms compile-fail #1532 — duplexPair() export not wired
finished/error-false-option parity-fail #1532 — finished({error:false}) callback still fires on destroy(err)
compose/single-sync-fn compile-fail #1531 — compose(readable, asyncGenFn) single-fn form
readable/from-rejected-promise ✅ PASSES Perry already propagates promise rejection as error event

All 3 failures tracked in test-parity/known_failures.json with the granular issues — no CI gate impact. 1 free pass adds to the stream module's parity count.

This is genuinely the last layer of stream's documented surface area I can find — the remaining gaps are all impl work on existing tests, not missing coverage.

Ralph Küpper and others added 2 commits May 23, 2026 23:12
…syncGenFn), Readable.from(rejectedPromise) (#1531/#1532)

Iter-26 stream tests covering the last documented surface gaps:
- duplex-pair/wired-comms: paired Duplex bidirectional in-memory pipe (#1532, compile-fail)
- finished/error-false-option: opt-out of error-event callback firing (#1532, parity-fail)
- compose/single-sync-fn: compose(readable, asyncGenFn) single-fn form (#1531, compile-fail)
- readable/from-rejected-promise: Readable.from(Promise.reject) emits error — PASSES against Node
# Conflicts:
#	test-parity/known_failures.json
@proggeramlug
proggeramlug merged commit c09dc12 into main May 24, 2026
9 checks passed
@proggeramlug
proggeramlug deleted the feat/stream-iter26 branch May 24, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants