Repository navigation
test(parity): stream — duplexPair, finished({error:false}), compose(asyncGenFn), Readable.from(rejectedPromise) (#1531/#1532) - #1579
Merged
Conversation
…syncGenFn), Readable.from(rejectedPromise) (#1531/#1532) Iter-26 stream tests covering the last documented surface gaps: - duplex-pair/wired-comms: paired Duplex bidirectional in-memory pipe (#1532, compile-fail) - finished/error-false-option: opt-out of error-event callback firing (#1532, parity-fail) - compose/single-sync-fn: compose(readable, asyncGenFn) single-fn form (#1531, compile-fail) - readable/from-rejected-promise: Readable.from(Promise.reject) emits error — PASSES against Node
# Conflicts: # test-parity/known_failures.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iter-26 stream tests — final niche surface
Four genuinely-different tests for the last unaudited stream behaviors:
duplex-pair/wired-commsduplexPair()export not wiredfinished/error-false-optionfinished({error:false})callback still fires ondestroy(err)compose/single-sync-fncompose(readable, asyncGenFn)single-fn formreadable/from-rejected-promiseerroreventAll 3 failures tracked in
test-parity/known_failures.jsonwith the granular issues — no CI gate impact. 1 free pass adds to the stream module's parity count.This is genuinely the last layer of stream's documented surface area I can find — the remaining gaps are all impl work on existing tests, not missing coverage.