Skip to content

test(node): unskip readable constructor cases - #2040

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-stream-readable-class-cleanup
May 27, 2026
Merged

proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-stream-readable-class-cleanup

Conversation

@andrewtdiz

Copy link
Copy Markdown
Contributor

Summary

  • Remove two now-green classic Readable constructor known-failure entries.
  • Keep Writable, Duplex, Transform, and PassThrough constructor entries listed because they still mismatch Node.
  • No runtime or compiler changes.

Verification

  • PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module stream --filter classes/readable-constructor
  • PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module stream --filter classes/readable-no-read-fn
  • jq empty test-parity/known_failures.json
  • git diff --check -- test-parity/known_failures.json

DeepWiki

  • Local reference only: reference/deepwiki/deno-node-stream-readable-constructor-basics-2026-05-27.md

Non-goals

  • No cleanup for node-suite/stream/classes/writable-constructor.
  • No cleanup for node-suite/stream/classes/duplex-constructor.
  • No cleanup for node-suite/stream/classes/transform-constructor.
  • No cleanup for node-suite/stream/classes/passthrough-constructor.

@proggeramlug
proggeramlug merged commit 72eb482 into PerryTS:main May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants