Repository navigation
fix(fetch): Headers.forEach/entries on app.fetch() Response no longer SIGSEGVs (#5432) #5442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // #5432: `.forEach()` / `.entries()` on the Headers of a Response returned by a | ||
| // member-call `app.fetch(req)` (the Fetch-API / WinterCG server-handler shape | ||
| // Hono, itty-router, and Cloudflare Workers all use) SIGSEGV'd in | ||
| // js_array_forEach: the unregistered receiver let the static array-method fold | ||
| // rewrite `res.headers.forEach(cb)` into `Expr::ArrayForEach` and codegen | ||
| // dispatched `js_array_forEach` on the Headers handle id (0x40000 band). | ||
| // `app.fetch` is modeled here without hono so the test needs no npm package — | ||
| // the crash is the member-`.fetch()` call returning a native Response, not hono | ||
| // itself. The assertions filter to the explicit `x-` headers so the test does | ||
| // not depend on whether a default `content-type` is derived from the body. | ||
| class App { | ||
| fetch(_req: Request): Response { | ||
| return new Response("ok", { headers: { "x-a": "1", "x-b": "2" } }); | ||
| } | ||
| } | ||
|
|
||
| const app = new App(); | ||
| const res = app.fetch(new Request("http://h/x")); | ||
| console.log("status:", res.status); | ||
|
|
||
| // forEach must iterate (used to SIGSEGV). | ||
| const seen: string[] = []; | ||
| res.headers.forEach((value: string, key: string) => { | ||
| if (key.startsWith("x-")) seen.push(key + "=" + value); | ||
| }); | ||
| seen.sort(); | ||
| console.log("forEach:", JSON.stringify(seen)); | ||
|
|
||
| // entries() must yield the same pairs (used to silently yield 0). | ||
| const ents: string[] = []; | ||
| for (const [k, v] of res.headers.entries()) { | ||
| if (k.startsWith("x-")) ents.push(k + "=" + v); | ||
| } | ||
| ents.sort(); | ||
| console.log("entries:", JSON.stringify(ents)); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propagate fetch-response local tracking across simple aliases.
fetch_call_response_localsis only set for direct.fetch(...)initializers. A follow-up alias (const alias = res) is not tracked, soalias.headers.forEach/entriescan still miss the intended headers path.Proposed patch
if is_member_fetch_call(init_expr) { ctx.fetch_call_response_locals.insert(name.clone()); + } else if let ast::Expr::Ident(src_ident) = init_expr.as_ref() { + if ctx + .fetch_call_response_locals + .contains(src_ident.sym.as_ref()) + { + ctx.fetch_call_response_locals.insert(name.clone()); + } }📝 Committable suggestion
🤖 Prompt for AI Agents