fix cargo clippy warning and error #351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peternator7
reviewed
May 5, 2024
| } | ||
| #[test] | ||
| fn generics_test() { | ||
| let foo = LifeTimeTest::One(Cow::Borrowed("Hello")); |
Owner
There was a problem hiding this comment.
Was clippy complaining about this? It doesn't on my machine, and I prefer we avoid changing variables names based on personal preference
There was a problem hiding this comment.
I think it complains about foo only in nightly. I agree it could be ignored for now.
Peternator7
requested changes
May 5, 2024
Owner
Peternator7
left a comment
Peternator7
left a comment
There was a problem hiding this comment.
Thanks for fixing the clippy errors. I'd prefer we don't change the test case names unless they're getting flagged for something that I'm not seeing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix cargo clippy warning and error