Fix offline dev update confirm handler not starting upload#2393
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Mar 10, 2026
Merged
Fix offline dev update confirm handler not starting upload#2393samfreund merged 1 commit intoPhotonVision:mainfrom
samfreund merged 1 commit intoPhotonVision:mainfrom
Conversation
github-actions
Bot
added
the
frontend
samfreund
approved these changes
Mar 10, 2026
SpeedSlicer
pushed a commit
to SpeedSlicer/photonvision
that referenced
this pull request
Mar 30, 2026
…ion#2393) Fixes a bug where offline update did not start after confirming the dev-version warning dialog. The confirm action was using an incorrect file reference in template context, so the selected JAR was not passed correctly to the upload handler. The dialog closed, but no upload request was sent. This change corrects the confirm handler so the selected file is passed properly and the upload/install flow starts as expected.
cswilson252
pushed a commit
to cswilson252/photonvision
that referenced
this pull request
Apr 22, 2026
…ion#2393) Fixes a bug where offline update did not start after confirming the dev-version warning dialog. The confirm action was using an incorrect file reference in template context, so the selected JAR was not passed correctly to the upload handler. The dialog closed, but no upload request was sent. This change corrects the confirm handler so the selected file is passed properly and the upload/install flow starts as expected.
samfreund
added a commit
that referenced
this pull request
May 5, 2026
We recently had an error that would've been caught by type checking in the frontend (see #2393). This PR implements type checking so that future errors will be caught. Additionally, this PR contains miscellaneous frontend cleanup that's tangentially related to type-checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed? Why? (the code + comments should speak for itself on the "how")
Fixes a bug where offline update did not start after confirming the dev-version warning dialog.
The confirm action was using an incorrect file reference in template context, so the selected JAR was not passed correctly to the upload handler. The dialog closed, but no upload request was sent.
This change corrects the confirm handler so the selected file is passed properly and the upload/install flow starts as expected.
Fix #2392
Meta
Merge checklist: