Depends on gfx-rs?

[jasonroelofs]

I'd like to request that 5bd14ff be reverted. Piston tries to set up an environment where you can choose SDL2 or GLFW separately from the rendering library in question, whether it be opengl_graphics, gfx_graphics, etc, depending on what you want. This commit now forces gfx on everyone who wants to use SDL2 with Piston, breaking this contract Piston is trying to develop.

[jasonroelofs]

Specifically, in my case, I want to use piston, sdl2_game_window, and opengl_graphics. Because of this change I'm now forced to include gfx, gfx_gl, gfx_macros, device, and render, which is currently putting me unable to work on my project because one of these has a syntax error with the latest Rust build.

[coeuvre]

I agree with you.

Since gfx was broken, I have to drop it in my local sdl2_game_window clone and make every repos point to it to do further development these days.

[coeuvre]

Maybe we should design a new architecture which people can choose between sdl2_game_window and glfw_game_window while underlying the window implementation they can still choose between opengl_graphics and gfx_graphics.

[bvssvni]

We can add a notice to README about how to set up gfx and let the user do this manually.

[bvssvni]

I added notice to both READMEs and removed the Gfx dependency.

@coeuvre Would you mind updating piston-examples? I got a problem with Rust nightlies on mac. PistonDevelopers/piston#647

Opened up a new issue for discussing a better architecture PistonDevelopers/piston#648

Closing.

[coeuvre]

Sure.

You problem must be rust-lang/rust#17192 that you can't get the latest nightly rust on mac. Since it was merged, you can try now.