Skip to content

Bump gradle-dependencies: kotlinx-collections-immutable and okhttp#2317

Merged
theovilardo merged 16 commits into
PixelPlayerHQ:masterfrom
Veridian-Zenith:master
Jun 11, 2026
Merged

Bump gradle-dependencies: kotlinx-collections-immutable and okhttp#2317
theovilardo merged 16 commits into
PixelPlayerHQ:masterfrom
Veridian-Zenith:master

Conversation

@daedaevibin

@daedaevibin daedaevibin commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

dependabot Bot and others added 7 commits June 9, 2026 22:30
@dependabot
chore(deps): bump the gradle-dependencies group across 1 directory wi…
6315557 
…th 3 updates

Bumps the gradle-dependencies group with 3 updates in the / directory: [org.jetbrains.kotlinx:kotlinx-collections-immutable](https://github.com/Kotlin/kotlinx.collections.immutable), [com.squareup.okhttp3:okhttp](https://github.com/square/okhttp) and [com.squareup.okhttp3:logging-interceptor](https://github.com/square/okhttp).


Updates `org.jetbrains.kotlinx:kotlinx-collections-immutable` from 0.4.0 to 0.5.0
- [Release notes](https://github.com/Kotlin/kotlinx.collections.immutable/releases)
- [Changelog](https://github.com/Kotlin/kotlinx.collections.immutable/blob/master/CHANGELOG.md)
- [Commits](Kotlin/kotlinx.collections.immutable@v0.4.0...v0.5.0)

Updates `com.squareup.okhttp3:okhttp` from 5.3.2 to 5.4.0
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-5.3.2...parent-5.4.0)

Updates `com.squareup.okhttp3:logging-interceptor` from 5.3.2 to 5.4.0
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-5.3.2...parent-5.4.0)

Updates `com.squareup.okhttp3:logging-interceptor` from 5.3.2 to 5.4.0
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-5.3.2...parent-5.4.0)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlinx:kotlinx-collections-immutable
  dependency-version: 0.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gradle-dependencies
- dependency-name: com.squareup.okhttp3:okhttp
  dependency-version: 5.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gradle-dependencies
- dependency-name: com.squareup.okhttp3:logging-interceptor
  dependency-version: 5.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gradle-dependencies
- dependency-name: com.squareup.okhttp3:logging-interceptor
  dependency-version: 5.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gradle-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@daedaevibin
Merge pull request #30 from Veridian-Zenith/dependabot/gradle/gradle-…
839ce9f 
…dependencies-fb73c85883

chore(deps): bump the gradle-dependencies group across 1 directory with 3 updates
@daedaevibin
Fix CodeQL build failure and update Netty for security
8d9523a
@daedaevibin @github-advanced-security
Fix for Unused import
e2f1d1a 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dае Еuнша <daedaevibin@ik.me>
@daedaevibin
Merge pull request #31 from Veridian-Zenith/finding-autofix-1
b8c5659 
Fix for Unused import
@daedaevibin
Merge branch 'theovilardo:master' into master
e31a95d
@daedaevibin
feat(lyrics): enhance multi-language lookup and matching
76e1841 
- Improved metadata cleaning to support Asian brackets and separators.
- Added romanization support for Japanese, Chinese, and Korean in title/artist matching.
- Introduced romanized search strategy for non-Latin titles.
- Implemented fuzzy matching for non-spaced languages (CJK).
- Expanded timing variant keywords for better track identification.
@daedaevibin

daedaevibin commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@theovilardo

Pull Request: Comprehensive Improvements to Lyrics Engine, UI, and Build System

This Pull Request introduces significant enhancements to the PixelPlayer lyrics engine for better global support, migrates deprecated UI components to modern Compose APIs, and updates core dependencies for improved stability and performance.

🚀 Key Improvements

1. Enhanced Multi-Language Lyrics Lookup & Matching

The primary focus of this update is to make lyric lookups as reliable for international music as they are for English tracks.

  • Romanization Integration: The matching logic now uses MultiLangRomanizer to compare tracks using Romanized titles and artists. This bridges the gap when your local metadata is Romanized but the lyric provider (LRCLIB) uses original scripts (Japanese, Chinese, Korean, etc.), or vice versa.
  • CJK Fuzzy Matching: Implemented a "contains" matching fallback for non-spaced languages (Chinese, Japanese) to handle minor metadata discrepancies.
  • Robust Metadata Cleaning:
    • Added support for a wide range of regional brackets (e.g., 【 】, 『 』, 「 」) and separators (e.g., －, ·, ・).
    • Expanded the ignore-list for timing variants like Opening, Ending, TV Size, and OST to improve search precision.
  • Romanized Search Strategy: Automated fallback search using Romanized titles for tracks in non-Latin scripts.

2. UI & Compose Modernization

  • BottomSheet Migration: Updated DailyMixMenu.kt to use the latest rememberBottomSheetState (replacing the deprecated rememberModalBottomSheetState) with an explicit SheetValue.Hidden initial state, aligning with modern Material 3 practices.
  • Code Cleanup: Removed redundant compiler arguments (-Xannotation-default-target=param-property) from the build configuration.

3. Build System & Dependency Updates

  • Dependency Upgrades:
    • okhttp: 5.3.2 → 5.4.0
    • netty: 4.2.15.Final → 4.2.17.Final
    • kotlinxCollectionsImmutable: 0.4.0 → 0.5.0
  • Wear OS Build Safety: Improved versionCode and versionName parsing in wear/build.gradle.kts to prevent build failures when properties are missing or improperly formatted.

4. CI/CD & Maintenance

  • Security: Updated the CodeQL analysis workflow to ensure the project remains compliant with the latest security scanning standards.
  • Tooling: Minor cleanup of the migrate_presentation_strings.py utility script.

🛠 Testing Performed

  • Multi-language Search: Verified improved hit rates for tracks in Japanese (Kanji/Kana), Chinese (Hanzi), and Korean (Hangul).
  • UI Interaction: Confirmed the Daily Mix bottom sheet functions correctly with the new state management.
  • Build Verification: Successful assembleDebug on both :app and :wear modules.

Note: This PR also includes updated local CodeQL database metadata and build logs resulting from recent CI/CD testing.

daedaevibin and others added 9 commits June 10, 2026 19:25
@daedaevibin
Update cache configuration for Gradle setup
293cfa3 
Signed-off-by: Dае Еuнша <daedaevibin@ik.me>
@daedaevibin
Change Gradle cache provider to 'enhanced'
e9f5a03 
Signed-off-by: Dае Еuнша <daedaevibin@ik.me>
@daedaevibin
Update CodeQL workflow for Kotlin compatibility
764009e 
Signed-off-by: Dае Еuнша <daedaevibin@ik.me>
@daedaevibin
fix(codeql): add continue-on-error to Kotlin pinning step
4b49eb1
@daedaevibin
security: update Netty to 4.2.28.Final to address vulnerabilities
619d483
@daedaevibin
Improve Kotlin version pinning in codeql.yml
874b523 
Updated Kotlin version pinning in CodeQL workflow for better compatibility.

Signed-off-by: Dае Еuнша <daedaevibin@ik.me>
@daedaevibin @github-code-quality
Apply suggested fix to app/src/main/java/com/theveloper/pixelplay/dat…
68fbd5d 
…a/repository/LyricsRepositoryImpl.kt from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Dае Еuнша <daedaevibin@ik.me>
@daedaevibin @github-code-quality
Apply suggested fix to app/src/main/java/com/theveloper/pixelplay/dat…
d435cc7 
…a/repository/LyricsRepositoryImpl.kt from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Signed-off-by: Dае Еuнша <daedaevibin@ik.me>
@daedaevibin
Merge pull request #32 from Veridian-Zenith/ai-findings-autofix/app-s…
b05ddcc 
…rc-main-java-com-theveloper-pixelplay-data-repository-LyricsRepositoryImpl.kt

Potential fixes for 2 code quality findings
@theovilardo theovilardo merged commit 4a8a2fc into PixelPlayerHQ:master Jun 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daedaevibin @theovilardo