Skip to content

Use newer ditto/update python #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
version: 2.1

executors:
python36:
python3:
docker:
- image: cimg/python:3.6.15
- image: cimg/python:3.12.3

commands:
ditto-transform:
description: Run Ditto in order to transform the BASE_URL instead of http://localhost
steps:
- run:
name: Install requirements.txt
command: pip install --user -r requirements.txt
name: Install Ditto
command: pip install --user 'pokeapi-ditto==1.0.2'
- run:
name: Transform api-data's JSON files to have the correct BASE_URL instead of http://localhost
command: bash -x scripts/transform.sh

jobs:
test:
executor: python36
executor: python3
steps:
- checkout
- ditto-transform
build-and-deploy:
executor: python36
executor: python3
steps:
- checkout
- ditto-transform
Expand Down
File renamed without changes.
11 changes: 0 additions & 11 deletions requirements.txt

This file was deleted.

4 changes: 2 additions & 2 deletions updater/cmd.bash
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ git branch -D "$BRANCH_NAME" || true
git branch "$BRANCH_NAME"
git checkout "$BRANCH_NAME"

pip install -r requirements.txt
rm -r ./data
pip install 'pokeapi-ditto==1.0.2'
rm -rf ./data
ditto clone --src-url http://localhost/ --dest-dir ./data
# (╯°□°)╯ *always* assume magikarp failed and grab it again #clowntown
ditto clone --src-url http://localhost/ --dest-dir ./data --select pokemon/129
Expand Down