Skip to content

Conversation

@Davidy22
Copy link
Contributor

@Davidy22 Davidy22 commented Jul 25, 2021

Fixes for #24, #26 and #28, start of pre-commit hooks for cleanliness with a passthrough of black, dep version bump and associated fixes. The addition of pre-commit hooks and the associated auto-formatting are in commit bc42b1b

Davidy22 added 5 commits July 24, 2021 11:12
Changed import of assume to match new hypothesis layout, should still work with prior hypothesis version where it was in both places at once.
Automated pass of pre-commit run on repo
@Kronopt Kronopt requested a review from GregHilmes July 25, 2021 17:42
@Naramsim
Copy link
Member

Hmm, why Travis hasn't run? Can you please configure your fork to run Travis @Davidy22?

@Naramsim
Copy link
Member

Mmm, it seems that Travis has switched from .org to .com and I cannot link anymore this project...

Maybe a good time to switch to GH Actions?

@Davidy22
Copy link
Contributor Author

Davidy22 commented Jul 27, 2021

Enabled travis on the repo and made a cursory commit, green check and all. May add an action some time to run pre commit on github side too. Not sure why green check doesn't show here, but I do have a green check on my repo

Copy link
Collaborator

@GregHilmes GregHilmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good. Thanks for contributing!

@GregHilmes GregHilmes merged commit bc797d4 into PokeAPI:master Jul 31, 2021
@C-Garza C-Garza mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants