Skip to content

Conversation

@DahanDv
Copy link
Contributor

@DahanDv DahanDv commented Dec 13, 2023

As written in the issue log, the support for 3.6-7 is very limiting;
hence so few version bumps are possible without running into dependencies nightmares.

@DahanDv DahanDv marked this pull request as ready for review December 13, 2023 12:43
@DahanDv
Copy link
Contributor Author

DahanDv commented Dec 13, 2023

@Naramsim Good to go by me.

@Naramsim
Copy link
Member

Can you bump the version in the setup.py? And remove python 3.6 support?

@DahanDv
Copy link
Contributor Author

DahanDv commented Dec 13, 2023

Can you bump the version in the setup.py?

Sure

And remove python 3.6 support?

Do you mean the commit message? I overrode its content; I'll squash it fine? (not 100% sure I understand your intent)

@Naramsim
Copy link
Member

Naramsim commented Dec 14, 2023

Nono, I meant here:

version, bump to 1.4.0: https://github.com/PokeAPI/pokebase/blob/master/setup.py#L12

drop support: https://github.com/PokeAPI/pokebase/blob/master/setup.py#L23

@DahanDv
Copy link
Contributor Author

DahanDv commented Dec 14, 2023

Done! :D

@Naramsim Naramsim merged commit 9132ddc into PokeAPI:master Dec 14, 2023
@Naramsim
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants