-
Notifications
You must be signed in to change notification settings - Fork 34
GitHub action automated retry #2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
+ Coverage 63.62% 71.33% +7.71%
==========================================
Files 56 54 -2
Lines 2161 1769 -392
Branches 287 217 -70
==========================================
- Hits 1375 1262 -113
+ Misses 729 458 -271
+ Partials 57 49 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment
id: deploy | ||
run: make deploy | ||
env: | ||
POLICYENGINE_DB_PASSWORD: ${{ secrets.POLICYENGINE_DB_PASSWORD }} | ||
GOOGLE_APPLICATION_CREDENTIALS: ${{ secrets.GCP_SA_KEY }} | ||
POLICYENGINE_GITHUB_MICRODATA_AUTH_TOKEN: ${{ secrets.POLICYENGINE_GITHUB_MICRODATA_AUTH_TOKEN }} | ||
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }} | ||
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
HUGGING_FACE_TOKEN: ${{ secrets.HUGGING_FACE_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue, blocking: This is pretty flagrantly not DRY (Don't Repeat Yourself)
There must be a way of doing this that allows for retries on failure via a single GitHub Action key. Please find it in the documentation and use that instead.
@SongmingFan123 please link #2366, not #2394, which is a PR, and thus cannot be fixed |
Updated, thank you. |
Fixes #2366