Prefer ZCTA over FIPS for all microsim contexts #6102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
approved these changes
Jun 6, 2025
MaxGhenis
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PolicyEngine/policyengine-api#2553.
This code ensures that for all microsimulations, including those that specify county FIPS for all households, the county FIPS values are ignored and ZCTA-based regions are used instead. This prevents bugs around county FIPS encoding that are prevalent throughout the API due to type inferences made automatically by
pandasaround the creation of dataframes.I am unsure on how to test these changes and would love guidance from @PavelMakarchuk on how to proceed.