🐛 Correct Async Backing migrations

[lrazovic]

Dependency Updates:

• Updated multiple dependencies in Cargo.toml files to stable2412-5 version.

Code Refactoring:

• Refactored the Vesting storage definition in pallets/linear-release/src/lib.rs to use a type alias (EntriesOf<T>) for better readability and maintainability. [1] [2]
• Removed unused imports and redundant features such as parachains-common references in various files, simplifying the codebase. [1] [2] [3] [4]

Test Enhancements:

• Enhanced migration test cases in pallets/funding/src/migrations/vesting_info.rs to include assertions for database weight and migration entry counts, ensuring correctness and performance validation. [1] [2]
• Adjusted test logic in pallets/funding/src/tests/runtime_api.rs to fix expected index values during vesting schedule merging operations.

Runtime and Benchmark Adjustments:

• Updated runtime benchmarks and feature configurations in several Cargo.toml files to align with the updated dependencies and removed deprecated entries. [1] [2] [3]

Performance Tweaks:

• Increased the authoring_duration in nodes/parachain/src/service.rs from 500ms to 2000ms to optimize block authoring performance if asynchronous backing is enabled.

[lrazovic]

• 🔖 Release Polimec 1.1.0 #481
• ✅ Add XCM Transact emulator tests #480
• 🐛 Correct Async Backing migrations #479 👈 (View in Graphite)
• ✨ Allow XCM Transact  #477
• 🏗️ Migrate pallet staking to use new block time #478
• 🏗️ Vesting pallet block number provider migration #474 : 1 other dependent PR (#476 )
• 🏗️ Linear release block number provider migration #473
• 🏗️ Funding pallet migration for enabling async backing #472
• ✨ Prepare pallets for async backing #471
• ⬆️ Upgrade to Polkadot SDK stable2412-2 #470
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dastansam]

not sure about fetching block number for every translate

[dastansam]

lgtm

[graphite-app]

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/01/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

[Copilot]

Pull Request Overview

This pull request fixes migration-related issues and adjusts various configuration parameters to correctly reflect runtime expectations. Key changes include renaming and updating migration types in the polimec runtime, modifying on-chain weight calculations and migration logic in vesting and linear-release modules, and adjusting benchmark and slot duration settings in Cargo.toml and mock configurations.

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
runtimes/polimec/src/lib.rs	Updated imports/constants and renamed the custom migration type for vesting to AsyncBacking.
runtimes/polimec/src/custom_migrations/vesting.rs	Renamed migration type and refined per_block and weight calculation logic using checked_div and ensure!
pallets/parachain-staking/src/mock.rs	Adjusted SlotDuration from 12,000 ms to 6,000 ms.
pallets/linear-release/src/migrations.rs & tests	Updated migration logic from multiplying to division in per_block adjustments and adjusted tests.
pallets/funding/src/tests/runtime_api.rs	Changed expected merge candidate indices in vesting schedule merge tests.
Various Cargo.toml files and integration tests	Updated dependency versions and removed duplicate runtime benchmarks.
nodes/parachain/src/service.rs	Increased authoring_duration from 500ms to 2000ms for consensus service parameters.

Comments suppressed due to low confidence (2)

runtimes/polimec/src/lib.rs:198

• The migration type has been renamed from UncheckedMigrationToV1 to UncheckedMigrationToAsyncBacking. Please update the associated documentation and comments to reflect this change consistently.

super::custom_migrations::vesting::v1::UncheckedMigrationToAsyncBacking<Runtime>,

pallets/funding/src/tests/runtime_api.rs:440

• The expected vesting schedule merge indices have changed from (0, 1) to (1, 2). Please verify that this adjustment aligns with the intended business logic and update any related documentation or tests if necessary.

assert_eq!((idx_1, idx_2), (1, 2));

[Copilot]

The additional increments added to items in the DB weight calculation should be clearly documented. Please consider adding a comment explaining why 1 and 2 are added respectively to the read and write counts.

Suggested change

	// Add 1 to the read count to account for the read operation on `VESTING_ASYNC_BACKED_KEY`.
	// Add 2 to the write count to account for the write operation on `VESTING_ASYNC_BACKED_KEY`
	// and any additional writes performed during the migration.

[Copilot]

The slot duration was reduced from 12,000 to 6,000 ms. Please ensure that this change is intentional and update the documentation to reflect the new expected block production rate.

Suggested change

	type MaxAuthorities = MaxCollatorCandidates;
	type MaxAuthorities = MaxCollatorCandidates;
	// SlotDuration determines the time interval (in milliseconds) between block production attempts.
	// The value was changed from 12,000 ms to 6,000 ms to increase the block production rate.
	// Ensure this change is intentional and update related documentation accordingly.

[lrazovic]

Merge activity

• May 2, 7:23 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• May 2, 7:37 AM EDT: Graphite rebased this pull request as part of a merge.
• May 2, 7:38 AM EDT: @lrazovic merged this pull request with Graphite.