build: Move build config to pyproject.toml
#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaty
force-pushed
the
dbaty/simplify_setup_py
branch
4 times, most recently
from
3a47369 to
908c07f
Compare
We can build the C extension on ReadTheDocs, so we can get rid of the
`optional` argument in `Extension()` in `setup.py`. The rest of the
build config can be moved to `pyproject.toml`.
A warning appears when building:
.../setuptools/config/pyprojecttoml.py:72: _ExperimentalConfiguration: `[tool.setuptools.ext-modules]` in `pyproject.toml` is still *experimental* and likely to change in future releases.
... but it's the only difference. So let's be adventurous and put
everything in `pyproject.toml`! :)
dbaty
force-pushed
the
dbaty/simplify_setup_py
branch
from
908c07f to
76bd6c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can build the C extension on ReadTheDocs, so we can get rid of the
optionalargument inExtension()insetup.py. The rest of thebuild config can be moved to
pyproject.toml.A warning appears when building:
... but it's the only difference. So let's be adventurous and put
everything in
pyproject.toml! :)