Skip to content

Use USD in place of POLY #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 6, 2019
Merged

Use USD in place of POLY #539

merged 11 commits into from
Feb 6, 2019

Conversation

adamdossa
Copy link
Contributor

@adamdossa adamdossa commented Feb 1, 2019 •
edited
Loading

Use USD pricing instead of POLY for ticker registration, token generation and module costs.

All prices are now denominated in USD, and converted to POLY at the point in time the transaction is executed.

Possible concern is calculating the correct amount of POLY to approve / transfer ahead of the operation, but this could be mitigated by a more stable oracle.

@adamdossa
WIP
c3336b5
@adamdossa
WIP
494f330 
Failed to add file
contracts/modules/Experimental/TransferManager/SingleTradeVolumeRestrict
ionTMFactory.sol to index.
@adamdossa
Remove old file
a73a763
@adamdossa
Fix migrations
560f69f
@adamdossa
Fixes and test cases
a889af3
@adamdossa
Some fixes
56e8c7b
@adamdossa
Fix lots of tests
7fc3851
@adamdossa
More fixes
8bb9840
@adamdossa
Update lots more tests
7914848
@adamdossa adamdossa changed the title WIP: Use USD in place of POLY Use USD in place of POLY Feb 5, 2019
@coveralls
Copy link

coveralls commented Feb 6, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 96.784% when pulling 08f43d9 on Use-USD-in-place-of-POLY into a87b16a on dev-3.0.0.

maxsam4
maxsam4 suggested changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@maxsam4 maxsam4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Just some code comments need updating.

satyamakgec
satyamakgec approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@satyamakgec satyamakgec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already reviewed the PR but forgot to Approved....

@adamdossa adamdossa merged commit 25e8f0e into dev-3.0.0 Feb 6, 2019
@satyamakgec satyamakgec deleted the Use-USD-in-place-of-POLY branch October 30, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsam4 maxsam4 maxsam4 approved these changes

@satyamakgec satyamakgec satyamakgec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamdossa @coveralls @maxsam4 @satyamakgec