add getTokensByDelegate #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsam4
suggested changes
Feb 9, 2019
contracts/SecurityTokenRegistry.sol
Outdated
| return token; | ||
| } | ||
| } | ||
| return token; |
There was a problem hiding this comment.
Shouldn't we return address(0) here?
There was a problem hiding this comment.
It will return automatically the address(0) I think as you read data from the eternal storage.
There was a problem hiding this comment.
I meant for the case when token exists but the owner is someone else.
satyamakgec
approved these changes
Feb 9, 2019
contracts/SecurityTokenRegistry.sol
Outdated
| return token; | ||
| } | ||
| } | ||
| return token; |
There was a problem hiding this comment.
It will return automatically the address(0) I think as you read data from the eternal storage.
maxsam4
approved these changes
Feb 11, 2019
maxsam4
pushed a commit
that referenced
this pull request
Apr 8, 2019
* Add getTokensByDelegate * Simple check * Add more test cases * Add interface file * minor fix
maxsam4
pushed a commit
that referenced
this pull request
Apr 8, 2019
* Add getTokensByDelegate * Simple check * Add more test cases * Add interface file * minor fix
adamdossa
pushed a commit
that referenced
this pull request
Apr 11, 2019
* Initial circleci script * circle ci run fixed * Added global truffle installation * Added sudo to global install * Added coverage, parallelism * Workflow fixed * Removed parallelism * WIP * CircleCI changes * CircleCI changes * CircleCI changes * Badge * Store test results * Removed coverage from commit workflow * Fix merge conflict * Addded artifact collection * Added parallelism * Comment * Bumped parallelism to 3 * Coverage requires approval * Bumped parallelism to 4 * Removed manual approval * Combine travis and CircleCI * env var changes * comment * Increased no o/p timeout * update contributing.md (#486) * Initial auto deploy * HDWalletProvider * Use local truffle * Deploy only on dev and master branches * Added deploy script * Enabled deployment on commit * Deploy only on dev/master branches * Add files via upload * Force overrite existing solc * Fix reading factory address from module registry for dividends modules * Alternative symbol() ABI for ERC20 tokens * STO fixes (#583) * Minor STO changes * typo fix * Added STO interface * Typo fixed * Refund remaining amount in last cappedsto tx * Finalize changed granularity edge case fixed (#588) * Added libz3-dev * Updated circleci image * Updated solidity-docgen * Added git identity * Generate docs only on merge to master * USDTieredSTO Granularity edge case fixed (#595) * sto granularity edge case fixed * Added test case * gtm matm optimizations (#601) * MATM optimizations * Added code comments * Updated tests * Updated names * Added overflow check * Fixes * Allow maturity / expiry dates to be updated * Add tests & fixes * Typo * More tests * Add more test cases * Update versions * Only bump dividends * Fix decimals in dividends modules * STOs are listed with its version * Reclaim ETH and ERC20 tokens from STO and Dividends modules * Pause/Unpase dividend modules * Minor fix * BigNumber library for dividends * STO selection fix * Fix for pause/unpause STOs * Show sto version when selecting * Updated Kovan addresses * Version info for all modules * audit fixes 1..9 * add test cases for the major issue * test fix * improve the test run * add the startTime == 0 check * resolve the edge case when the investors restriction changes * Minor change * VRTM size reduction to 24.21KB * Reduced VRTM size to be under the limit * add the code comments * increase the time to fix the coverage * optimize the code * updated readme with 2.1.0 mainnet addresses * Fix to keep transfer_manager compatible with GTM v1.0.0 * docs update & minor improvements * Use bokky's timestamp library in scheduled checkpoint (#466) * added enum TimeUnit * update depends on timeUnit * test for monthly checkpoint * tests for monthly checkpoint * use UTC instead of local time * minor fix * Tests for yearly checkpoint * Tests for last day of month * Updated tests for last day of month * commented failed test * fix for end of month schedule * refactored _update function * added TimeUnits: DAYS, WEEKS * add getTokensByDelegate (#547) * Add getTokensByDelegate * Simple check * Add more test cases * Add interface file * minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add getTokensByDelegate: