Fix for issue myELM327.supportedPIDs_1_20() not working as expected … #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome. Also, thank you so much for helping me fix up the loose ends of this library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue with incorrect values being returned from findResponse() even though the received bytes were correct. The bug was caused by bit shifting the uint8_t value returned by ctoi() by more than 8 bits (undefined behaviour). Fix is to cast the result of ctoi() to uint64_t before doing the left shift.
Also note in the issue #157, the sample code has a bug were the pids var is a signed int, which will cause an error; it should be unsigned. See example program Check_PIDs_1_20.ino for a working version.