-
Notifications
You must be signed in to change notification settings - Fork 34
(DOCS) Update CLI reference and conceptual docs for v3.0.0 #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
(DOCS) Update CLI reference and conceptual docs for v3.0.0 #672
Conversation
8322bb9
to
84a9cd8
Compare
69f79fe
to
18a2eee
Compare
--------------------------------------------------------------- | ||
DesiredStateConfiguration-Preview 9PCX3HX4HZ0Z Unknown msstore | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a small remark for the users telling something like:
[!INFO]
You can use eithermsstore
orwinget
as the source. When usingwinget
, it leverages the.zip
file, whereasmsstore
uses the.msixbundle
.
18a2eee
to
690ae7e
Compare
Prior to this change, the docs folder didn't include any conceptual documentation, only reference documents. This change copies existing concept docs into the folder, updates them for GA, and adds new conceptual documentation to make it easier for new users to learn about DSC and start using it.
This change updates the reference docs for: - `Microsoft/OSInfo` resource - `osinfo` CLI tool - `Microsoft.Windows/Registry` resource - `registry` CLI tool These are the only resources currently documented on the live docs site.
690ae7e
to
de65bee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need more time to go through all the docs
type: Microsoft.Windows/Registry | ||
result: | ||
actualState: | ||
keyPath: HKCU\example\key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enclose in single quotes so that the backslash doesn't need to be escaped
keyPath: HKCU\example\key | |
keyPath: 'HKCU\example\key' |
- Export a new configuration document with every instance of a set of resources with the | ||
`dsc config export` command. | ||
|
||
Configuration documents are YAML or JSON files that contain a single object. The object's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it help to mention relationship to ARM templates since those have more docs and examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And given the very positive reaction to Bicep at PS Summit, this makes it sound like we only support the two languages, when we actually support a third, as an abstraction of the JSON.
- Provides metadata about the operation as a whole and for each resource instance. | ||
|
||
```sh | ||
dsc config test --file /example.config.dsc.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dsc config test --file /example.config.dsc.yaml | |
dsc config test --file ./example.config.dsc.yaml |
Is this missing the period? Otherwise it's an absolute path
```json | ||
"json.schemas": [ | ||
{ | ||
"fileMatch": ["**/*.dsc.resource.json", ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"fileMatch": ["**/*.dsc.resource.json", ], | |
"fileMatch": ["**/*.dsc.resource.json"], |
- Export a new configuration document with every instance of a set of resources with the | ||
`dsc config export` command. | ||
|
||
Configuration documents are YAML or JSON files that contain a single object. The object's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration documents are YAML or JSON files that contain a single object. The object's | |
Configuration documents contain a single object formatted as YAML, JSON, or Bicep (which compiles to JSON). The object's |
`dsc config export` command. | ||
|
||
Configuration documents are YAML or JSON files that contain a single object. The object's | ||
properties define how DSC processes the document. The top-level properties for a document are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
properties define how DSC processes the document. The top-level properties for a document are: | |
properties define how DSC processes the document. It is intentional that DSC configuration documents | |
should be familiar to authors accustomed to working with | |
[Azure Resource Manager deployment templates](./azure/azure-resource-manager/templates/). | |
The top-level properties for a document are: |
### HyperText Markup Language (HTML) format | ||
|
||
HTML files can be viewed by web browsers such as **Microsoft Edge**. The following example shows | ||
how to save the output of a command to an HTML file. | ||
|
||
```powershell | ||
dsc resource list | ConvertFrom-Json | ConvertTo-HTML | Out-File .\myFile.html | ||
Invoke-Item .\myFile.html | ||
``` | ||
|
||
The `Invoke-Item` command opens the file in your default web browser. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### HyperText Markup Language (HTML) format | |
HTML files can be viewed by web browsers such as **Microsoft Edge**. The following example shows | |
how to save the output of a command to an HTML file. | |
```powershell | |
dsc resource list | ConvertFrom-Json | ConvertTo-HTML | Out-File .\myFile.html | |
Invoke-Item .\myFile.html | |
``` | |
The `Invoke-Item` command opens the file in your default web browser. |
unfortunately we need to remove these until an issue is resolved in PWSH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such as massive PR, it will be easier to "nit pick" using small PRs after it is published. At a high level, everything looks good to me.
PR Summary
This changeset updates and adds reference documentation for the
3.0.0
GA release of DSC.It includes:
Deferred to future PRs:
PR Context