-
Notifications
You must be signed in to change notification settings - Fork 50
Bug fixes. Should fix: #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @gravejester, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Nice! |
@gerane Turned out two of the issues were related, so easy fix :) Thanks for testing and finding these bugs btw! |
No problem. I should just be able to copy the TM language into code to try these changes out shouldn't I? I use code as my daily driver, and I have always liked themes, so I will be paying closer attention for anything off. |
Yes, just copy the language file over the existing one, and restart code. |
Thanks man! I'll take a look at this later today when I'm back in Athens. |
@gerane, did the fixes resolve the issues for you when you tried it? |
@@ -9,7 +9,7 @@ | |||
<string>psd1</string> | |||
</array> | |||
<key>name</key> | |||
<string>PowerShell</string> | |||
<string>Powershell</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, was this necessary to get VS Code to operate correctly? I wonder if it'd have a negative effect on other editors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.. that was just a visual help for me when working with the definitions in Sublime Text, as I had two versions of the language files installed :) I'll revert it back.
I haven't tried it yet. Got caught up in a bug in a vendor's product at
work. So I've wasted the last couple days dealing with foreign support I
can barely understand.
They blamed Microsoft like usual, even though I can't even begin to see how
it is related to Microsoft. I think that is just their go to answer.
|
I tested this out and it worked for me by updating "C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\powershell\syntaxes\PowershellSyntax.tmLanguage" |
Hey @gravejester, sorry for the delay on getting this merged. Done now! By the way, the VS Code team gave me write access to their repo so I should be able to approve your PRs there now ;) |
I'm still seeing some color coding issues even after replacing this file manually: Example 1:
Example 2:
Both work perfectly with VSCode 1.2.1 and vscode-powershell 0.6.1. Thanks for looking into this :) |
#9
#10
#11