Skip to content

Bug fixes. Should fix: #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2016
Merged

Bug fixes. Should fix: #12

merged 5 commits into from
Jul 13, 2016

Conversation

gravejester
Copy link
Contributor

@msftclas
Copy link

msftclas commented Jul 4, 2016

Hi @gravejester, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@gerane
Copy link

gerane commented Jul 4, 2016

Nice!

@gravejester
Copy link
Contributor Author

@gerane Turned out two of the issues were related, so easy fix :)

Thanks for testing and finding these bugs btw!

@gerane
Copy link

gerane commented Jul 5, 2016

No problem. I should just be able to copy the TM language into code to try these changes out shouldn't I?

I use code as my daily driver, and I have always liked themes, so I will be paying closer attention for anything off.

@gravejester
Copy link
Contributor Author

Yes, just copy the language file over the existing one, and restart code.

@daviwil
Copy link
Contributor

daviwil commented Jul 5, 2016

Thanks man! I'll take a look at this later today when I'm back in Athens.

@daviwil
Copy link
Contributor

daviwil commented Jul 7, 2016

@gerane, did the fixes resolve the issues for you when you tried it?

@@ -9,7 +9,7 @@
<string>psd1</string>
</array>
<key>name</key>
<string>PowerShell</string>
<string>Powershell</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, was this necessary to get VS Code to operate correctly? I wonder if it'd have a negative effect on other editors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah.. that was just a visual help for me when working with the definitions in Sublime Text, as I had two versions of the language files installed :) I'll revert it back.

@gerane
Copy link

gerane commented Jul 7, 2016 via email

@CodeCyclone
Copy link

I tested this out and it worked for me by updating "C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\powershell\syntaxes\PowershellSyntax.tmLanguage"

@daviwil
Copy link
Contributor

daviwil commented Jul 13, 2016

Hey @gravejester, sorry for the delay on getting this merged. Done now!

By the way, the VS Code team gave me write access to their repo so I should be able to approve your PRs there now ;)

@ftischhauser
Copy link

I'm still seeing some color coding issues even after replacing this file manually:

Example 1:

$email = "[email protected]"

Example 2:

$XML = @"
<?xml version="1.0" encoding="UTF-16"?>
    <test>powershell.exe -Command "&amp; {if($var.'$name'){Write-Output 'hello world'}}"</test>
"@
Write-Output 'hello world'

Both work perfectly with VSCode 1.2.1 and vscode-powershell 0.6.1.

Thanks for looking into this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants