Skip to content

Multiple fixes #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
May 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
3d38dc9
attribute and type fixes.
omniomi May 7, 2018
b285376
Merge branch 'master' into fix-attributes
omniomi May 7, 2018
dd78db5
rework attributes
omniomi May 7, 2018
8ec4203
fix ints within attribute
omniomi May 7, 2018
596b74d
type definition within attributes
omniomi May 7, 2018
fb3ed1f
fix strings in attribute
omniomi May 7, 2018
ce8b481
fix case for string include
omniomi May 7, 2018
ffe674a
Merge branch 'master' into fix-attributes
omniomi May 9, 2018
43adc5c
rescope types and attributes.
omniomi May 9, 2018
d684275
correct comments inline with attribute
omniomi May 9, 2018
8a1eccd
rescope variables.
omniomi May 9, 2018
363abb3
change end captures for attribute
omniomi May 9, 2018
3b3b6b7
fix double quoted strings.
omniomi May 9, 2018
3443647
rescope variable token for cosmetic reasons
omniomi May 9, 2018
9054995
first pass at fixing indices
omniomi May 9, 2018
5e1cd60
fix types and indices
omniomi May 10, 2018
4a76e10
fix digits in types (removed by accident.)
omniomi May 10, 2018
350afda
fix new line between ) and ] on attribute.
omniomi May 10, 2018
245b933
Merge branch 'master' into fix-attributes
omniomi May 11, 2018
f2d596e
restructure for CI
omniomi May 12, 2018
9643d45
setup build scripts
omniomi May 12, 2018
71e76aa
add spec file
omniomi May 12, 2018
cb17b0c
build script tweaks
omniomi May 12, 2018
a167d30
rescope comments
omniomi May 12, 2018
0304912
add build file to test step
omniomi May 12, 2018
ee6cf1a
add self to attribute
omniomi May 12, 2018
99dbcc4
advanced function tests.
omniomi May 12, 2018
5eb93a1
better descriptions for automatic tests
omniomi May 12, 2018
9fa738f
make the build script pretty
omniomi May 12, 2018
71ccafc
appveyor -> run tests
omniomi May 12, 2018
b4005bf
fix section name
omniomi May 12, 2018
8653186
fix atom path variable
omniomi May 12, 2018
8d9f7fd
add exit condition
omniomi May 12, 2018
ca322d2
class specs
omniomi May 13, 2018
3732a5c
fix variable scope
omniomi May 13, 2018
59b6411
variable scoping - closing brace
omniomi May 13, 2018
ed9efd6
correct hashtable scopes
omniomi May 13, 2018
acbb1c7
rescope numerics.
omniomi May 13, 2018
a46c5ac
remove redundancy.
omniomi May 13, 2018
3444f13
missed a numeric scope.
omniomi May 13, 2018
4513595
fix range operator for negative numbers
omniomi May 13, 2018
4fdc78d
scope array tokens
omniomi May 13, 2018
7b0e5a3
correct interpolation parens scope
omniomi May 13, 2018
e8d79c2
scriptblock scopes
omniomi May 13, 2018
31f82c9
the big spec file... first half.
omniomi May 13, 2018
cd98976
fix xml typo
omniomi May 14, 2018
ba1c16d
fix xml typo
omniomi May 14, 2018
1221f4b
stop parameter names that match keywords from highlighting
omniomi May 15, 2018
0eec1d0
add default keyword
omniomi May 15, 2018
6e7ff50
tweak function keyword scopes.
omniomi May 15, 2018
6963b0d
Make build.ps1 crossplatform
vors May 15, 2018
d10981b
stop function end capture from clobbering other scopes
omniomi May 15, 2018
1ac11a7
more scoping in big test file.
omniomi May 15, 2018
aed153e
remove dependence on build.ps1
omniomi May 15, 2018
cbb0735
remove dependence on build.ps1
omniomi May 15, 2018
825f177
Merge pull request #1 from vors/fix-attributes-fix-build-mac
omniomi May 15, 2018
e604866
comments between function def and K&R bracket
omniomi May 15, 2018
12230bb
Update readme.
omniomi May 15, 2018
bb2087b
correct subexpression punctuation scopes.
omniomi May 15, 2018
36b6140
finish big spec file.
omniomi May 15, 2018
e544dbc
change test to a switch param in build.ps1
omniomi May 15, 2018
1571f62
newline at EOF
omniomi May 16, 2018
608a859
fix email addresses within strings
omniomi May 16, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
syntaxes/
tools/node_modules/
grammars/
node_modules/
atom/
atom.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add new line at the end of file (here and in other files)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, Google told me. Will do.

2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ Fixing issues also does not require a lot of administrative work. The basic step

## Reviews

We are using GitHub's internal capabilities for our code reviews. Either we, the EditorSyntax team, or you, the community, can review the changes and add comments. The author of the pull request can then go through all issues, fix them and add commits to his branch, which will show up in the pull request. When all issues are fixed and there is nothing else to do, we will gladly merge your pull request.
We are using GitHub's internal capabilities for our code reviews. Either we, the EditorSyntax team, or you, the community, can review the changes and add comments. The author of the pull request can then go through all issues, fix them and add commits to his branch, which will show up in the pull request. When all issues are fixed and there is nothing else to do, we will gladly merge your pull request.
Loading