Skip to content

Implemented ConsoleKeyInfoConverterAttribute + tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Implemented ConsoleKeyInfoConverterAttribute + tests #6

wants to merge 1 commit into from

Conversation

oising
Copy link
Contributor

@oising oising commented May 22, 2013

  • added parameter positional hints to set-psreadlinehandler
  • implemented sequence parsing, examples:
    -- "x"
    -- "escape"
    -- "shift+]"
    -- "}"
    -- "ctrl+alt+q"
    -- "shift+backspace"
    -- "ctrl+oem6"
  • added unit tests

@lzybkr
Copy link
Contributor

lzybkr commented May 22, 2013

Newlines seem messed up.

@lzybkr lzybkr closed this May 22, 2013
@oising
Copy link
Contributor Author

oising commented May 22, 2013

I just re-did the work, and the culprit is visual studio's integrated commit command (the one on the right click menu.) I verified the diffs with "git diff" on the command line first and all was good. After I committed in VS, I diffed the changesets: Completely screwed again.... wtf. I'll redo it and use git commit in the msys shell instead. Bah.
-Oisin

Date: Wed, 22 May 2013 10:25:25 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [PSReadLine] Implemented ConsoleKeyInfoConverterAttribute + tests (#6)

Newlines seem messed up.


Reply to this email directly or view it on GitHub.

@oising
Copy link
Contributor Author

oising commented May 24, 2013

OK, so it was still screwed when I used git directly. Eventually I figured out I need to set this:
git config --global core.autocrlf true
..and now everything is fixed for me.
I've sent another pull request.
-Ois

From: [email protected]
To: [email protected]; [email protected]
Subject: RE: [PSReadLine] Implemented ConsoleKeyInfoConverterAttribute + tests (#6)
Date: Wed, 22 May 2013 19:10:13 +0000

I just re-did the work, and the culprit is visual studio's integrated commit command (the one on the right click menu.) I verified the diffs with "git diff" on the command line first and all was good. After I committed in VS, I diffed the changesets: Completely screwed again.... wtf. I'll redo it and use git commit in the msys shell instead. Bah.
-Oisin

Date: Wed, 22 May 2013 10:25:25 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [PSReadLine] Implemented ConsoleKeyInfoConverterAttribute + tests (#6)

Newlines seem messed up.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants