Skip to content

Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions#113

Merged
yutingc merged 2 commits into
PowerShell:BugFixesfrom
GoodOlClint:BugFixes
May 7, 2015
Merged

Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions#113
yutingc merged 2 commits into
PowerShell:BugFixesfrom
GoodOlClint:BugFixes

Conversation

@GoodOlClint

Copy link
Copy Markdown
Contributor

Community rule OUT-04

The comment on line 44 seems like this was already the intended behavior, but the rule appears to be triggering regardless if [CmdletBinding()] is specified or not.

Re-opening per #99 and #100 to merge into BugFixes, includes unit tests

@msftclas

msftclas commented May 7, 2015

Copy link
Copy Markdown

Hi @GoodOlClint, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas

msftclas commented May 7, 2015

Copy link
Copy Markdown

@GoodOlClint, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@yutingc

yutingc commented May 7, 2015

Copy link
Copy Markdown
Contributor

Thanks @GoodOlClint for signing the agreement and adding the unit test. We will merge the changes. Thanks.

@raghushantha

Copy link
Copy Markdown
Member

Hi GoodOlClint. Your changes look good. And thank you for adding tests.

-Raghu

yutingc added a commit that referenced this pull request May 7, 2015
Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions
@yutingc yutingc merged commit 1177959 into PowerShell:BugFixes May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants