Skip to content

Added instruction to get public modules from PSGallery #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

thomasrayner
Copy link
Contributor

PR Summary

Fixes #1326 . An error occurs while building PSScriptAnalyzer if one is missing dependencies and has a private repository added.

PR Checklist

@thomasrayner
Copy link
Contributor Author

Since I didn't modify global.json, I'm not sure the build failure is a result of this PR.

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)
Can't wait to see what other changes you are going to make now that you are building PSSA :-)
Hmm, the build failure on Ubuntu is odd. It's not your fault but we actually fixed a very similar problem with the Ubuntu build just this week and it's broken again :-( (the breaking changes are due to updates of the image and AppVeyor being sensitive to exit codes that the .Net teams has changed over time, we've got a PR to migrate to Azure Pipelines but ironically there are a few tests that somehow do not pass in Azure pipelines. at the moment...)
I can confirm that the current build got broken again as I just kicked off a new build on master, sorry for that

@thomasrayner
Copy link
Contributor Author

👋 @bergmeister! I'm having too much fun messing with AST-related stuff to not try and get some of it into PSSA.

And no problem regarding the failed build stuff. Let me know if there's anything you want me to change, or commits that I should pull into my branch.

@bergmeister bergmeister merged commit 94e8573 into PowerShell:master Sep 3, 2019
@thomasrayner thomasrayner deleted the install-module-issue branch September 4, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build script fails when you have private PSRepositories
2 participants