Skip to content

New Best practice formatting #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2015
Merged

New Best practice formatting #136

merged 5 commits into from
May 11, 2015

Conversation

yutingc
Copy link
Contributor

@yutingc yutingc commented May 11, 2015

Will close the old pull request.

- -ComputerName hardcoded should not be used (information disclosure)[AvoidUsingComputerNameHardcoded](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/RuleDocumentation/AvoidUsingComputerNameHardcoded.md)
- - ConvertTo-SecureString with plaintext should not be used (information disclosure)
-
###Severity: Warning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown is not rendered correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@raghushantha
Copy link
Member

pls push the change. The initial draft looks good.

yutingc added a commit that referenced this pull request May 11, 2015
@yutingc yutingc merged commit 12f937a into master May 11, 2015
@vors vors removed the in progress label May 11, 2015
@yutingc
Copy link
Contributor Author

yutingc commented May 11, 2015

Thanks!

@yutingc yutingc deleted the BestPractice branch May 12, 2015 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants