Fix typo in example#1379
Merged
bergmeister merged 2 commits intoPowerShell:masterfrom Dec 3, 2019
Farwaykorse:patch-2
Merged
Conversation
bergmeister
reviewed
Dec 3, 2019
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
Thanks for making it consistent.
I am happy with the proposed change but I think we could improve it further by making 2 more changes:
- Use the full parameter name, which is
-Settingsin both examples - Replace
PSScriptAnalyzerSettings.psd1in the 2 examples with$PSScriptAnalyzerSettingsPath. This is because using-Settings PSScriptAnalyzerSettings.psd1is redundant due to the implicit settings feature.
Let me know what you think.
Contributor
Author
|
I agree with the use of I wouldn't use the variable, it just adds confusion over the meaning of the variable. The current use of |
Collaborator
|
Ok, happy with that as well, it is definitely an improvement. Thanks 😀 |
bergmeister
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the script name to match the name in the example.
Removed the
when using. It belonged with thewhen using Invoke-ScriptAnalyzerused in the previous example and repeating that seems unnecessary.