Skip to content

Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 29, 2020
Merged

Use separate test.yaml files files since param passing of pwsh still doesn't seem to fully work correctly #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
92df6c4
Pass pwsh parameter explicitly as runtime parameter
Apr 25, 2020
f270590
fix yaml
Apr 25, 2020
f60a154
try use compile time expression
Apr 25, 2020
637b3bc
cannot cast to bool, use string
Apr 25, 2020
517ba15
compile time expressions everywhere
Apr 25, 2020
ca76515
Revert "compile time expressions everywhere"
Apr 25, 2020
3af2262
runtime expr
Apr 25, 2020
01a7d39
try use $() expression and don't pass parameter
Apr 27, 2020
8eed77d
try re-add param section
Apr 27, 2020
66cb8ab
try use bracket again
Apr 27, 2020
fc361a3
try split test template
Apr 27, 2020
5d40207
Merge branch 'master' of https://github.com/powershell/psscriptanalyz…
Apr 27, 2020
90ad293
re-enable build
Apr 27, 2020
765748d
remove duplicated entry
bergmeister Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .azure-pipelines-ci/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ stages:
vmImage: vs2017-win2016
Windows_Server2019_PowerShell_Core:
vmImage: windows-2019
pool:
vmImage: $[ variables['vmImage'] ]
steps:
- template: templates/test-pwsh.yaml
- job:
strategy:
matrix:
Windows_Server2016_PowerShell_5_1:
vmImage: vs2017-win2016
pwsh: false
Expand All @@ -43,4 +50,4 @@ stages:
pool:
vmImage: $[ variables['vmImage'] ]
steps:
- template: templates/test.yaml
- template: templates/test-powershell.yaml
7 changes: 1 addition & 6 deletions .azure-pipelines-ci/templates/test.yaml → ...pelines-ci/templates/test-powershell.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
parameters:
- name: pwsh
type: boolean
default: true

steps:
- task: DownloadPipelineArtifact@2
displayName: 'Download Pipeline Artifact: out Folder'
Expand All @@ -13,7 +8,7 @@ steps:
displayName: 'Test'
inputs:
targetType: inline
pwsh: $[ parameters.pwsh ]
pwsh: false
script: |
Import-Module .\tools\appveyor.psm1
Invoke-AppveyorTest -CheckoutPath $env:BUILD_SOURCESDIRECTORY
Expand Down
19 changes: 19 additions & 0 deletions .azure-pipelines-ci/templates/test-pwsh.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
steps:
- task: DownloadPipelineArtifact@2
displayName: 'Download Pipeline Artifact: out Folder'
inputs:
artifactName: out
targetPath: '$(Build.SourcesDirectory)/out'
- task: PowerShell@2
displayName: 'Test'
inputs:
targetType: inline
pwsh: true
script: |
Import-Module .\tools\appveyor.psm1
Invoke-AppveyorTest -CheckoutPath $env:BUILD_SOURCESDIRECTORY
- task: PublishTestResults@2
inputs:
testRunner: NUnit
testResultsFiles: 'TestResults.xml'
condition: succeededOrFailed()