Fix crash in ScriptRule parsing when PowerShell help system is not initialized on a machine #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good. One question I have is that will adding update-help impact the perfomance? Will it hang a few seconds? |
|
The perf impact is negligible because of: Verified this on a clean-install machine. |
|
Also, the build is failing since appveyor changes are not integrated with BugFixes |
raghushantha
added a commit
that referenced
this pull request
May 15, 2015
Fix crash in ScriptRule parsing when PowerShell help system is not initialized on a machine
|
But do we need to call update-help each time when we import customized rule? Is there a way to only download help when there was no "get-help"? |
|
Update-Help optimizes this. it sets up a registry key after the first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified the fix in elevated/non-elevated environment with/without help system initialization