Rule to validate the presence of Verbose statements in DSC Resource #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return AstVisitAction.Continue; | ||
| } | ||
| List<string> expectedTargetResourceFunctionNames = new List<string>(new string[] { "Set-TargetResource", "Test-TargetResource", "Get-TargetResource" }); |
There was a problem hiding this comment.
I don't think we use this anywhere in the code?
There was a problem hiding this comment.
Quoc. I did not understand your comment.
Since this rule is enabled only for cmdlet based DSC resources, we do not need to validate for advanced functions...
There was a problem hiding this comment.
Oh I mean the DscResourceFunctions in the Helper class already takes out the set, get and test targetresource functions. Also what I mean is we didn't use the variable expectedTargetResourceFunctionNames anywhere in this file?
|
good catch. Updated the pull request with changes |
|
Looks good to me. |
|
thanks. I will merge once Appveyor is clean |
raghushantha
added a commit
that referenced
this pull request
Jun 10, 2015
…ranch Rule to validate the presence of Verbose statements in DSC Resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.