Handle assembly loading errors at composition time #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation of MEF's DirectoryCatalog does not
handle ReflectionTypeLoadExceptions that occur when assemblies
in the specified directory are loaded. This causes the full
assembly loading process to stop, meaning that no rules will
be found. When running Script Analyzer in a folder with a lot
of DLLs, this type of error becomes more likely. This change
introduces a new SafeDirectoryCatalog type which is more
resilient to this problem.
Also, there is a check that determines whether any rules have
been loaded before continuing. This check was prone to throwing
NullReferenceExceptions when MEF composition fails. I changed
that logic to be more resilient to potential null values.