Skip to content

Fix for Issue #371 #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2015
Merged

Fix for Issue #371 #374

merged 2 commits into from
Nov 25, 2015

Conversation

kilasuit
Copy link
Contributor

Removes Auth from the list of searched terms for the AvoidUsingPlainTextPasswords Rule

@msftclas
Copy link

Hi @kilasuit, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@raghushantha
Copy link
Member

Hi Ryan. Thank you for the fix.

Please update the failing test case:

Describing AvoidUsingPlainTextForPassword
Context When there are violations
[-] has 3 avoid using plain text for password violations 192ms
Expected: {5}
But was: {4}
at line: 12 in C:\projects\psscriptanalyzer\Tests\Rules\AvoidUsingPlainTextForPassword.tests.ps1
12: $violations.Count | Should Be 5
[+] has the correct violation message 14ms
Context When there are no violations
[+] returns no violations 145ms

@kilasuit
Copy link
Contributor Author

My bad will do this now :-)

@raghushantha
Copy link
Member

Great. Thanks!

raghushantha added a commit that referenced this pull request Nov 25, 2015
@raghushantha raghushantha merged commit b5c991b into PowerShell:development Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants