Skip to content

Fixes to UseToExportFieldsInManifest rule. #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2016
Merged

Fixes to UseToExportFieldsInManifest rule. #453

merged 4 commits into from
Feb 22, 2016

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Feb 18, 2016

This commit now enables handling of single values along with of arrays.

Review on Reviewable

@raghushantha
Copy link
Member

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

Rules/UseToExportFieldsInManifest.cs, line 100 [r2] (raw file):
Don't need the else part. Just return false outside of the if statement.

Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

Rules/UseToExportFieldsInManifest.cs, line 120 [r2] (raw file):
Same comment as before.

Comments from the review on Reviewable.io

@kapilmb
Copy link
Author

kapilmb commented Feb 22, 2016

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

Rules/UseToExportFieldsInManifest.cs, line 100 [r2] (raw file):
Done.

Rules/UseToExportFieldsInManifest.cs, line 120 [r2] (raw file):
Done.

Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

kapilmb pushed a commit that referenced this pull request Feb 22, 2016
Merge pull request #453 from PowerShell/FixUseToExportFieldsInManifest
e74ea46 
Fixes to UseToExportFieldsInManifest rule.
@kapilmb kapilmb merged commit e74ea46 into development Feb 22, 2016
@kapilmb kapilmb deleted the FixUseToExportFieldsInManifest branch February 22, 2016 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapilmb @raghushantha @lzybkr @msftclas