Fix loading custom rules that do not have comment help #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conditions to check if indexing does not take place on a null valued Value property. If a PowerShell based custom rule does't have comment based help, the engine throws an error. This occurs because the lack of comment based help results in a null value for the Value property of the dynamically typed description variable.
|
Changes look good. I will sign-off after the Appveyor issue is taken care of. Dev builds are failing. Comments from the review on Reviewable.io |
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
Reviewed 1 of 1 files at r2. Comments from the review on Reviewable.io |
kapilmb
pushed a commit
that referenced
this pull request
Mar 14, 2016
Fix loading custom rules that do not have comment help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditions to check if indexing does not take place on a null valued Value property.
If a PowerShell based custom rule does't have comment based help, the engine throws an error. This occurs because the lack of comment based help results in a null value for the Value property of the dynamically typed description variable.
Fixes #463
This change is