Fix severity filtering while invoking script analyzer #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters the rules based on their severity before passing them the AST for analysis. Prior to the fix, the severity filter was applied on diagnostic records. This was inefficient as Invoke-ScriptAnalyzer would run all the rules irrespective of the given severity and then filter the diagnostic records to extract the results that corresponded to the given severity.
|
Good perf optimization. thanks for the fix. Comments from the review on Reviewable.io |
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
Rules are filtered prior to creating tasks (threads). This avoids creating unnecessary tasks as opposed to the earlier approach where rule invocation was decided within their corresponding tasks.
|
Comments from the review on Reviewable.io |
|
Reviewed 1 of 1 files at r2. Comments from the review on Reviewable.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters the rules based on their severity before passing them the AST for
analysis.
Prior to the fix, the severity filter was applied on diagnostic records.
This was inefficient as Invoke-ScriptAnalyzer would run all the rules
irrespective of the given severity and then filter the diagnostic records
to extract the results that corresponded to the given severity.
This change is