Skip to content

Add rule to check for consistent whitespace style #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Feb 6, 2017
Merged

Add rule to check for consistent whitespace style #702

merged 40 commits into from
Feb 6, 2017

Conversation

@kapilmb
Copy link

@kapilmb kapilmb commented Feb 6, 2017 •
edited by raghushantha
Loading

This change is Reviewable

Kapil Borle added 30 commits January 30, 2017 14:23
Add skeleton of UseWhitespace rule
d9da319
Add method to find tokens with preceding whitespace
820538f
Check for whitespace before open brace
294ab5c
Add Ast property to TokenOperations
4d97359
Add method to return token nodes
3e9f988
Add error strings for UseWhitespace rule
7af55b8
Find open parenthesis violations
1b80017
Add tests for UseWhitespace rule
688a881
Update open brace violation finder implementation
3450c95
Add configuration in each test case
a868ed5
Update GetTokenNodes method in TokenOperations
e7a7b95
Add error string for operator violation
7347add
Add logic to detect operator violations
b158d50
Add tests for operator violations
5cbe9a1
Remove duplicate code from UseWhitespace rule
02a0b9d
Add corrections for bracket violations
da59328
Add a constructor to CorrectionExtent class
c06bf1f
Add corrections for operator violations
5e534b6
Check keywords for open paren violation
00dd0c4
Update UseWhitespace rule test cases
dca518b
Detect comma and semicolon violations
f886a29
Add tests for comma and semicolon detection
acd4de7
Add UseWhitespace rule to codeformatting settings
d2581f6
Update tests for usewhitespace rule
d683d46
Update IsPreviousTokenOnSameLine method logic
92f64b6
Update separator violation logic
7a421a8
Add corrections for separator violations
139754e
Fix corrections for operator violations
18f9668
Remove redundant code from operator violations
81a241f
Use same correction method for operator/separator violation
578fd98
@kapilmb kapilmb mentioned this pull request Feb 6, 2017
Merged
daviwil
daviwil approved these changes Feb 6, 2017
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kapilmb kapilmb merged commit db46934 into development Feb 6, 2017
@kapilmb kapilmb deleted the kapilmb/use-whitespace-rule branch February 6, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@daviwil daviwil daviwil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kapilmb @daviwil @msftclas