Skip to content

Fix FixPSUseDeclaredVarsMoreThanAssignments to also detect variables that are strongly typed #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Dec 3, 2017

Fix issue #832
The problem was this line:

// Only checks for the case where lhs is a variable. Ignore things like $foo.property
VariableExpressionAst assignmentVarAst = assignmentAst.Left as VariableExpressionAst;

[string]$someVariable is a ConvertExpressionAst in this case and therefore I needed to do some work to get the VariableExpressionAst out of it in this case

@JamesWTruher JamesWTruher merged commit a2ab2de into PowerShell:development Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants