-
Notifications
You must be signed in to change notification settings - Fork 396
Add -EnableExit switch to Invoke-ScriptAnalyzer for exit and return exit code for CI purposes #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
27e4ddc
Add -EnableExit switch
bergmeister 9bae52c
fix yaml in markdown file
bergmeister 9421b2c
fix LibraryUsage.tests.ps1 for -EnableExit switch
bergmeister 349be0b
fix LibraryUsage.tests.ps1 to return results
bergmeister a26ecd2
add test for -EnableExit switch
bergmeister fcfe48c
Fix test by waiting for the powershell process to finish and improve …
bergmeister 21295ed
Add -EnableExit switch to Invoke-ScriptAnalyzer cmdlet documentation …
bergmeister 91d1c4f
Call powerShell directly to avoid using unsupported (in pwsh) WindowS…
bergmeister c5b5cec
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you have is fine, but would this also work?
Eventually, I would like to see these be portable on other platforms, and the
-WindowStyle
parameter isn't portable. Eventually, we also need to calculate the name ofpowershell
(since it can be powershell or pwsh, but that can be ignored for now)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is possible. I have changed it to that.