Skip to content

Adapt release script and documentation due to upgrade to .Net Core 2.0 #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Adapt release script and documentation due to upgrade to .Net Core 2.0 #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff01b9a
Remove 'dotnet restore' step in New-ReleaseBuild function because thi…
bergmeister Feb 4, 2018
1b66637
update readme with update to csproj
bergmeister Feb 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ Creating a Release
- Update changelog (`changelog.md`) with the new version number and change set. When updating the changelog please follow the same pattern as that of previous change sets (otherwise this may break the next step).
- Import the ReleaseMaker module and execute `New-Release` cmdlet to perform the following actions.
- Update module manifest (engine/PSScriptAnalyzer.psd1) with the new version number and change set
- Update the version number in `engine/project.json` and `rules/project.json`
- Update the version number in `Engine/Engine.csproj` and `Rules/Rules.csproj`
- Create a release build in `out/`

```powershell
Expand Down
1 change: 0 additions & 1 deletion Utils/ReleaseMaker.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ function New-ReleaseBuild
try
{
remove-item out/ -recurse -force
dotnet restore
.\buildCoreClr.ps1 -Framework net451 -Configuration Release -Build
.\buildCoreClr.ps1 -Framework net451 -Configuration PSV3Release -Build
.\buildCoreClr.ps1 -Framework netstandard1.6 -Configuration Release -Build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be netstandard2.<something>?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? The idea behind .net standard is to keep the number as low as possible. Unless we need an API that is available only in netstandard2.0, there is no value (the standard itself has nothing to do with the runtime, the runtime is responsible for implementing the standard). But maybe give that we are not running on mobile devices, this is maybe over thinking and netstandard2 might make it easier for development by having more apis available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that the more we match PowerShell Core the better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I don't mind too much if you prefer that but changing to netstandard2.0 should be done as a separate PR.

Expand Down