Use https links where possible #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
commented
Feb 5, 2018
| @@ -23,7 +23,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands | |||
| /// <summary> | |||
| /// GetScriptAnalyzerRuleCommand: Cmdlet to list all the analyzer rule names and descriptions. | |||
| /// </summary> | |||
| [Cmdlet(VerbsCommon.Get, "ScriptAnalyzerRule", HelpUri = "http://go.microsoft.com/fwlink/?LinkId=525913")] | |||
| [Cmdlet(VerbsCommon.Get, "ScriptAnalyzerRule", HelpUri = "https://go.microsoft.com/fwlink/?LinkId=525913")] | |||
There was a problem hiding this comment.
This link only re-directs to https://github.com/PowerShell/PSScriptAnalyzer/
Should we change it then to that?
bergmeister
commented
Feb 5, 2018
| @@ -39,7 +39,7 @@ namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands | |||
| "ScriptAnalyzer", | |||
| DefaultParameterSetName = "File", | |||
| SupportsShouldProcess = true, | |||
| HelpUri = "http://go.microsoft.com/fwlink/?LinkId=525914")] | |||
| HelpUri = "https://go.microsoft.com/fwlink/?LinkId=525914")] | |||
There was a problem hiding this comment.
This link only re-directs to https://github.com/PowerShell/PSScriptAnalyzer/
Should we change it then to that?
There was a problem hiding this comment.
the fwlink is fine - it's the way we handle links so it need not change if we move the repo. The real question is whether pointing to github is appropriate. I think for now it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #799
All links where checked and upgraded to https where possible.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready