Skip to content

Improve the & background operator (consistency with bash, richer functionality) #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

KirkMunro
Copy link
Contributor

No description provided.

@KirkMunro KirkMunro changed the title first draft Improve the & background operator (consistency with bash, richer functionality) Jun 18, 2019
@dragonwolf83
Copy link

Ok, so my comments are in reverse order, lol. First time clicking "Review". Makes more sense if you read the last comment first.

Copy link
Contributor

@joeyaiello joeyaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to do more async reviews outside of Committee meetings, so that means my review here is not binding by any means. Just giving my (often naive) take.

Right now, I'm okay with $! and the new ProcessId property, but I have concerns about console overlays, as well as the change to --% (which I don't believe can be easily implemented, though I'd love to be proven wrong). I think we should document workarounds (inline in my comments) around the --% scenario.

@KirkMunro
Copy link
Contributor Author

Trying to do more async reviews outside of Committee meetings, so that means my review here is not binding by any means. Just giving my (often naive) take.

This is very much appreciated. Even just a non-binding "gut" take from you guys on these is very helpful, so I thank you for that.

@joeyaiello
Copy link
Contributor

After some discussion, @PowerShell/powershell-committee feels that most of this proposal is not useful and/or straightforward enough to accept:

  • Muxing output streams from multiple jobs in an async interactive session sounds confusing to end users, and if it's just a simple tail you want, that can be accomplished with Receive-Job -Wait
  • We don't believe that $! has enough utility to be an automatic variable. You can already do things like $foo = 1..3 | % {start-job {$_}}

We did, however, agree that a ProcessId property would immensely useful to folks, and should probably be added to PSRemotingJob, but that can be handled purely in an issue.

At a high-level, we think there's some improvements we could make to the UX of the entire job system (especially using ThreadJobs), but it's not currently a priority for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants