Use global dotnet and update build dependencies
#1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
requested review from
TravisEz13,
JustinGrote and
SeeminglyScience
andyleejordan
force-pushed
the
andschwa/dotnet
branch
from
522f376 to
5fb8cfc
Compare
TravisEz13
reviewed
Feb 18, 2022
.vsts-ci/azure-pipelines-release.yml
Outdated
| @@ -29,7 +29,8 @@ stages: | |||
| jobs: | |||
| - job: Build | |||
| pool: | |||
| vmImage: windows-2019 | |||
| name: 1ES | |||
| demands: ImageOverride -equals PMMSWindows2019-Secure | |||
There was a problem hiding this comment.
Suggested change
| demands: ImageOverride -equals PMMSWindows2019-Secure | |
| demands: ImageOverride -equals PMMS2019-Secure |
TravisEz13
reviewed
Feb 18, 2022
.vsts-ci/azure-pipelines-release.yml
Outdated
| @@ -39,7 +40,7 @@ stages: | |||
| - job: Sign | |||
| pool: | |||
| name: 1ES | |||
| demands: ImageOverride -equals MMSWindows2019-Secure | |||
| demands: ImageOverride -equals PMMSWindows2019-Secure | |||
There was a problem hiding this comment.
Suggested change
| demands: ImageOverride -equals PMMSWindows2019-Secure | |
| demands: ImageOverride -equals PMMS2019-Secure |
andyleejordan
force-pushed
the
andschwa/dotnet
branch
from
5fb8cfc to
c4b38ba
Compare
TravisEz13
approved these changes
Feb 18, 2022
For secure and compliant builds, we must use the .NET SDK installed on the build machine, which means we cannot use the installation script any more. Additionally, that script explicitly says not to use it for developer machines either. While the bootstrapping cost is now slightly higher since the developer has to manually install the SDK (and additional runtime if necessary), this is what .NET instructs us to do. The good news is that developers no longer need to manually add this folder's `.dotnet` folder to the front of their `PATH` before opening VS Code for OmniSharp to work correctly. Plus, it's simpler.
andyleejordan
force-pushed
the
andschwa/dotnet
branch
from
c4b38ba to
c965f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our build script's dependency on the
install-dotnetscript (which is only meant for use in CI, but we now use an ADO task for that, and so that we can rely on pre-installed versions of .NET if available). Developers will need to follow .NET Core's instructions to install .NET SDK 6.0, and the 3.1 runtime for the end-to-end tests. Fortunately, this actually eases the developer workflow by no longer being sensitive to a local installation ofdotnet, so the C# extension in Code now "just works."This updates the release pipeline to use the
PMMSWindows2019-Securefor build, sign, and release.This also updates our required and installed
InvokeBuildandplatyPSmodules for the build, which is probably the most annoying part of this PR as devs will need to runUpdate-Modulefor these (and possibly installplayPSif they had never run the dependent task before).