Minor 0.9.0 fixes #341
Merged
Minor 0.9.0 fixes #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes PowerShell/vscode-powershell#408 which states that code action requests sent for diagnostic markers created by other extensions cause our language server to crash. This was due to us not handling the case where irrelevant diagnostics might (mistakenly?) get sent to us to resolve their code actions.
Today's VS Code Insiders release has started sending file requests with a file scheme of 'git' which causes a crash in our language server. This is a temporary fix until we add more robust file URI scheme handling with the fix to issue #342.
daviwil
force-pushed
the
daviwil/fix-vsc-390-408
branch
from
7f22985 to
8f82095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I've had these sitting around for a while and forgot to send a PR...