Skip to content

Conversation

@rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Mar 22, 2018

PSES currently only tests untagged Pester tests. This adds tests for recognising tagged Pester tests as Pester symbols.

This build should succeed with #638.

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt
Copy link
Contributor Author

rjmholt commented Mar 22, 2018

I noticed that the StopDebugger test is failing here too for some reason...

@rjmholt
Copy link
Contributor Author

rjmholt commented Mar 22, 2018

Oh, looks like it worked after being restarted

@TylerLeonhardt
Copy link
Member

So the test you wrote is failing. Is that on purpose?

@TylerLeonhardt
Copy link
Member

Oh I see. Need to do #638 first.

rjmholt and others added 9 commits March 22, 2018 11:07
* allow newer dotnet cli

* show correct version you are using

* use dotnetExe var
…ll#639)

* Add Start-EditorServices script from vscode-powershell repo

* Move Start-EditorServices to module and overwrite the old one

* Add EnableConsoleRepl flag

* Revert EnableConsoleRepl

* read session data from file

* add file length check as well

* add CoreCLR System.Reflection

* Fix issue with checking if session file available

Change to check length of sessionPath file and only if file exists test passes.
Update to use CodeBase which is the original location of the file under bin dir.  Location is in the temp dir when run under xUnit.
Fix issue with running xUnit tests over and over.  Have a better
way to detect when the session details file has been written.

Fix issue with ServiceReturnsPowerShellVersionDetails test,
where it only worked when you ran the tests using x86 arch.
It now runs correctly using x64.
* Implement better way to test for in-memory file

Fix PowerShell#569

PSES would crash quite often when the user viewed a ps1 file in a diff window
or an earlier version using GitLens.

This approach using the System.Uri class that can detect file vs other schemes.
URI chokes on relative file paths.  In this case, we fall back to the previous
approach of using Path.GetFullPath().

* Add unit tests and PTLE catch - just in case.

* Use test cases and a single Assert.

* Remove test value for verifying we get msg on test fail
Refactor pester script detection to parse tags correctly
@rjmholt rjmholt closed this Mar 26, 2018
@rjmholt rjmholt reopened this Mar 26, 2018
@rjmholt rjmholt closed this Mar 26, 2018
@rjmholt rjmholt reopened this Mar 26, 2018
@TylerLeonhardt
Copy link
Member

whatcha trying to do there, @rjmholt 😄

@rjmholt
Copy link
Contributor Author

rjmholt commented Mar 26, 2018

Think I should have it now.

Was trying to restart the tests, but realised I needed to rebase onto master first. So have now done that. Hopefully the new test will now pass and we can merge this one too.

@rjmholt
Copy link
Contributor Author

rjmholt commented Mar 26, 2018

Hmmm, I may have botched this. I'll just go from the new master.

@rjmholt rjmholt closed this Mar 26, 2018
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Mar 26, 2018

To restart the tests you have to go into Travis and AppVeyor. I was manually restarting them for you :)

@rjmholt
Copy link
Contributor Author

rjmholt commented Mar 27, 2018

Yes, I was trying to go to AppVeyor and I couldn't work out how to restart the test. Eventually I decided to open and close the PR to try and get them to rerun. I can restart tests in Travis with no problems, but looked everywhere in AppVeyor and couldn't see it.

@rjmholt rjmholt deleted the pester-tests branch December 12, 2018 06:02
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this pull request Feb 26, 2019
Code formatting strings are imperative, fixed PSScriptAnalyzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants