-
Notifications
You must be signed in to change notification settings - Fork 242
Add tests ensuring tagged pester tests still register as pester symbols #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rkeithhill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I noticed that the StopDebugger test is failing here too for some reason... |
|
Oh, looks like it worked after being restarted |
|
So the test you wrote is failing. Is that on purpose? |
|
Oh I see. Need to do #638 first. |
* allow newer dotnet cli * show correct version you are using * use dotnetExe var
…ll#639) * Add Start-EditorServices script from vscode-powershell repo * Move Start-EditorServices to module and overwrite the old one * Add EnableConsoleRepl flag * Revert EnableConsoleRepl * read session data from file * add file length check as well * add CoreCLR System.Reflection * Fix issue with checking if session file available Change to check length of sessionPath file and only if file exists test passes. Update to use CodeBase which is the original location of the file under bin dir. Location is in the temp dir when run under xUnit.
Fix issue with running xUnit tests over and over. Have a better way to detect when the session details file has been written. Fix issue with ServiceReturnsPowerShellVersionDetails test, where it only worked when you ran the tests using x86 arch. It now runs correctly using x64.
* Implement better way to test for in-memory file Fix PowerShell#569 PSES would crash quite often when the user viewed a ps1 file in a diff window or an earlier version using GitLens. This approach using the System.Uri class that can detect file vs other schemes. URI chokes on relative file paths. In this case, we fall back to the previous approach of using Path.GetFullPath(). * Add unit tests and PTLE catch - just in case. * Use test cases and a single Assert. * Remove test value for verifying we get msg on test fail
Refactor pester script detection to parse tags correctly
|
whatcha trying to do there, @rjmholt 😄 |
|
Think I should have it now. Was trying to restart the tests, but realised I needed to rebase onto master first. So have now done that. Hopefully the new test will now pass and we can merge this one too. |
|
Hmmm, I may have botched this. I'll just go from the new |
|
To restart the tests you have to go into Travis and AppVeyor. I was manually restarting them for you :) |
|
Yes, I was trying to go to AppVeyor and I couldn't work out how to restart the test. Eventually I decided to open and close the PR to try and get them to rerun. I can restart tests in Travis with no problems, but looked everywhere in AppVeyor and couldn't see it. |
Code formatting strings are imperative, fixed PSScriptAnalyzer
PSES currently only tests untagged Pester tests. This adds tests for recognising tagged Pester tests as Pester symbols.
This build should succeed with #638.