Skip to content

Add @rkeithhill's IPv6 socket fix to PSES startup script #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Apr 25, 2018

@rkeithhill fixed an issue with starting PSES on machines that don't support IPv6 sockets in PowerShell/vscode-powershell#1281.

But I migrated the startup script to PSES and left out that fix.

This puts it back in.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for quickly fixing this @rjmholt! Glad that we'll get @rkeithhill fix in 😃

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit 58fab2d into PowerShell:master Apr 25, 2018
@rjmholt rjmholt deleted the pses-ipv6-startup-fix branch April 25, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants