Backport: Fix issue with reference code lens not working with UNC paths (#908) #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hell#908) * Fix issue with reference code lens not working with UNC paths * Refactor to avoid extra Insert ops. Simplifies macOS/Linux code path. * Still need to unescape / on macOs & Linux * Replace compile-time check for .NET Core with runtime check
|
After this is merged, can we point a few folks that were having issues with this to the VSIX that gets built? I'd like to verify it fixes all the failure cases we've seen. There are a few out there, like the script parse NRE on extent that I'm not sure if this fixes. |
rjmholt
approved these changes
Apr 10, 2019
TylerLeonhardt
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with reference code lens not working with UNC paths
Refactor to avoid extra Insert ops. Simplifies macOS/Linux code path.
Still need to unescape / on macOs & Linux
Replace compile-time check for .NET Core with runtime check