Repository navigation
Add DSC feature - #1
Open
Thomas Nieto (ThomasNieto) wants to merge 2 commits into
Open
Thomas Nieto (ThomasNieto) wants to merge 2 commits into
Thomas Nieto (ThomasNieto) wants to merge 2 commits into
Conversation
Steve Lee (SteveL-MSFT)
requested changes
Aug 6, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Installation, PATH propagation, scenario execution, and blocking CI behavior contain unresolved functional issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a hosted Microsoft DSC dev container Feature, addressing PowerShell/DSC#1626.
Changes:
- Adds DSC installation, version selection, and documentation.
- Adds feature tests and CI validation/release workflows.
- Adds repository development-container configuration.
File summaries
| File | Description |
|---|---|
src/dsc/install.sh |
Downloads, installs, and verifies DSC. |
src/dsc/devcontainer-feature.json |
Defines Feature metadata and options. |
src/dsc/README.md |
Documents the DSC Feature. |
test/dsc/test.sh |
Tests default installation and PATH access. |
test/dsc/scenarios.json |
Defines version-specific scenarios. |
.github/workflows/test.yaml |
Runs Feature tests. |
.github/workflows/validate.yml |
Validates Feature metadata. |
.github/workflows/release.yaml |
Publishes Features and generated documentation. |
.devcontainer/devcontainer.json |
Configures repository development tooling. |
.devcontainer/devcontainer-lock.json |
Locks the development-container Feature. |
README.md |
Documents repository usage and DSC support. |
Review details
Suppressed comments (2)
.github/workflows/test.yaml:32
- Scenario failures are ignored at the job level, allowing missing or broken version-option tests to leave the workflow successful. Remove
continue-on-errorso these tests can block regressions.
continue-on-error: true
.github/workflows/test.yaml:48
- Global test failures are also marked non-blocking, so this validation cannot affect the workflow result. Remove
continue-on-errorhere as well.
continue-on-error: true
- Files reviewed: 11/11 changed files
- Comments generated: 10
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+121
to
+123
| if [ "${DSC_VERSION}" != "none" ]; then | ||
| install_dsc "${DSC_VERSION}" | ||
| fi |
Comment on lines
+12
to
+13
| continue-on-error: true | ||
| strategy: |
| ] | ||
| } | ||
| } | ||
| }, |
| # Function to get the latest DSC release version | ||
| get_latest_dsc_version() { | ||
| # Query GitHub API for the latest release (stable only) | ||
| curl -s https://api.github.com/repos/PowerShell/DSC/releases/latest | grep -oP '"tag_name":\s*"\K[^"]*' | head -1 || echo "" |
| temp_dir=$(mktemp -d) | ||
| cd "${temp_dir}" | ||
|
|
||
| if ! curl -sSL "${download_url}" -o dsc.tar.gz; then |
Comment on lines
+2
to
+5
| "dsc_latest": { | ||
| "image": "ubuntu:noble", | ||
| "features": { | ||
| "dsc": {} |
| **Supported Versions:** | ||
| - `latest` (default) - Latest stable release | ||
| - `preview` - Latest preview release | ||
| - `3.2.3`, `3.2.2`, `3.2.1`, `3.2.0` - Specific versions |
|
|
||
| | Options Id | Description | Type | Default Value | | ||
| |-----|-----|-----|-----| | ||
| | version | Select or enter a version of Microsoft DSC to install. Use 'latest' for the latest version, 'none' to skip DSC installation. | string | latest | |
|
|
||
| --- | ||
|
|
||
| _Note: This file was auto-generated from the [devcontainer-feature.json](https://github.com/devcontainers/features/blob/main/src/dsc/devcontainer-feature.json). Add additional notes to a `NOTES.md`._ |
| # Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information. | ||
| #------------------------------------------------------------------------------------------------------------- | ||
| # | ||
| # Docs: https://github.com/devcontainers/features/tree/main/src/dsc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add DSC feature
PR Context
Resolves PowerShell/DSC#1626